shared/utils/parse-package-param.ts (1)

54-61: Trailing @ edge case may produce unexpected results.

When the input ends with @ but has no version (e.g., 'esbuild@'), the function returns { name: 'esbuild@' } because the version slice is empty. This retains the trailing @ in the package name, which is not a valid npm package name.

Consider whether this should instead return { name: 'esbuild' } to strip the trailing @:

💡 Suggested fix

 export function parsePackageSpecifier(input: string): { name: string; version?: string } {
   const atIndex = input.startsWith('@') ? input.indexOf('@', 1) : input.indexOf('@')
   if (atIndex > 0) {
     const version = input.slice(atIndex + 1)
     if (version) return { name: input.slice(0, atIndex), version }
+    // Trailing @ with no version - return name without the @
+    return { name: input.slice(0, atIndex) }
   }
   return { name: input }
 }

modules/runtime/server/cache.ts (1)

222-238: Consider using parsePackageSpecifier to reduce code duplication.

This function contains inline parsing logic for extracting the package name and version specifier (lines 226-238) that duplicates the logic in parsePackageSpecifier. The same pattern appears in processSingleVersionsMeta (lines 300-312).

Since parsePackageSpecifier was introduced to centralise this parsing, consider refactoring these functions to use it for consistency and maintainability.

♻️ Suggested refactor

 async function processSingleFastNpmMeta(
   packageQuery: string,
   storage: ReturnType<typeof useStorage>,
   metadata: boolean,
 ): Promise<Record<string, unknown>> {
-  let packageName = packageQuery
-  let specifier = 'latest'
-
-  if (packageName.startsWith('@')) {
-    const atIndex = packageName.indexOf('@', 1)
-    if (atIndex !== -1) {
-      specifier = packageName.slice(atIndex + 1)
-      packageName = packageName.slice(0, atIndex)
-    }
-  } else {
-    const atIndex = packageName.indexOf('@')
-    if (atIndex !== -1) {
-      specifier = packageName.slice(atIndex + 1)
-      packageName = packageName.slice(0, atIndex)
-    }
-  }
+  const { name: packageName, version } = parsePackageSpecifier(packageQuery)
+  const specifier = version ?? 'latest'

test/unit/app/utils/router.spec.ts (1)

100-107: Consider adding a test case for undefined version.

The test covers null version but not undefined. Since the function signature accepts string | null | undefined, it would be good to explicitly test the undefined case for completeness.

💡 Suggested addition

   describe('with null/undefined version', () => {
     it('returns package route for null version', () => {
       expect(packageRoute('react', null)).toEqual({
         name: 'package',
         params: { org: '', name: 'react' },
       })
     })
+
+    it('returns package route for undefined version', () => {
+      expect(packageRoute('react', undefined)).toEqual({
+        name: 'package',
+        params: { org: '', name: 'react' },
+      })
+    })
   })

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro